Requires +page.{tj}s file when using sveltekit and Houdini

[lukaso]

Is there an existing issue for this?

• I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues
• I have reviewed the documentation https://docs.sentry.io/
• I am using the latest SDK release https://github.com/getsentry/sentry-javascript/releases

How do you use Sentry?

Sentry Saas (sentry.io)

Which SDK are you using?

@sentry/sveltekit

SDK Version

7.64.0

Framework Version

Sveltekit 1.22.4

Link to Sentry event

No response

SDK Setup

    Sentry.init({
      dsn: PUBLIC_SENTRY_DSN,
      tracesSampleRate: 1.0,

      // This sets the sample rate to be 10%. You may want this to be 100% while
      // in development and sample at a lower rate in production
      replaysSessionSampleRate: 0.1,

      // If the entire session is not sampled, use the below sample rate to sample
      // sessions when an error occurs.
      replaysOnErrorSampleRate: 1.0,

      // If you don't want to use Session Replay, just remove the line below:
      integrations: [new Replay()],
    });

Steps to Reproduce

1. Create a project
2. Set +layout.js or ts to export const ssr = false (don't know if this is relevant to reproducing)
3. Add in sentry
4. Create a route and add a +page.svelte
5. Do not create a +page.ts or a +page.js
6. Run the project using pnpm dev

Expected Result

The project runs

Actual Result

This happens for any page in the routes, so it doesn't matter what the path is.

Internal server error: ENOENT: no such file or directory, open '/src/routes/(app)/projects/[projectid]/settings/+page.js'
  
[Error: ENOENT: no such file or directory, open '/src/routes/(app)/projects/[projectid]/settings/+page.js'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: '/src/routes/(app)/projects/[projectid]/settings/+page.js'
}

[Lms24]

Hi @lukaso thanks for writing in!

I tried to reproduce this by following your reproduction instructions and I didn't encounter the mentioned error.

Can you please take a look at my reproduction and point out what to change so that the error occurs? Alternatively, please share your own reproduction (e.g. via a GH repo) so that we can investigate this further. Thanks!

[lukaso]

OK, a little progress. I haven't been able to reproduce it with your repo, but I've been able to stop the problem with mine. I added autoinstrument: true to the vite.config.js sentrySveltekit statement and the problem went away. No idea why.

Unfortunately, removing autoinstrument: true from yours (I restarted from scratch) isn't enough to bring the problem back and also, now, when I remove it from mine, the problem also doesn't come back.

I don't know if that helps a little. I'll try to reproduce it, but it seems very strange.

[lukaso]

Once I did an pnpm build however, that hadn't actually fixed the problem. Will keep digging.

[lukaso]

OK, I can reproduce it with this: https://github.com/lukaso/gh-sentry-javascript-8846-sveltekit-file-not-found/tree/reproduce

It appears there's a bad interaction between houdini and sentry.

[Lms24]

Thanks for tracking this down! I'll take a look at this next week, this week is kinda full already. Backlogged it for the moment.

[lukaso]

No problem. I have a workaround so it's fine for now.

[Lms24]

I looked into this and it seems like Houdini adds file ids to the build that didn't exist before, such as the aforementioned +page.js file. When our auto instrumentation plugin's load hook is called, we previously tried to read the file id (if the filename matched +(page|layout)(.server)?.(js|ts)) and didn't check if the file actually existed.

Consequently, the ids added by Houdini matched our filename filter, we tried to read them and... the build crashed because the file didn't exist.

I opened #8881 to guard reading the file by checking for its existence.

Note, I didn't find the code responsible for adding these file ids in Houdini. cc @jycouet @AlecAivazis is this intended behaviour? Are these files added so that Houdini can be used in routes without previously existing +page.ts (etc) files? As I said we can easily guard for this but just wanted to let you know that this might be problematic for other plugins as well.

[lukaso]

Thanks for figuring this out! Really appreciated. Which version will the fix land in (if you know)?

[Lms24]

I just merged the fix so it'll go out in the next release. This will either be 7.65.1 or 7.66.0 (depending on what else we merge in). You can expect it to be released sometime this or, latest, next week.