Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): Mark errors caught from HttpClient and CaptureConsole integrations as unhandled #8891

Merged
merged 3 commits into from Sep 5, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 29, 2023

This PR is part of a series of PRs adjusting the exception mechanism's handled value.

For more details see #8890

Changed Instrumentation

This PR addresses the mechanisms set in the integrations package, more concretely in the

  • HttpClient
  • CaptureConsole

integrations.

ref #6073

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.32 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.21 KB (-0.01% 🔽)
@sentry/browser - Webpack (gzipped) 21.83 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 69.84 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.16 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.15 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 220.72 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 85 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 59.71 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.06 KB (-0.01% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.34 KB (-0.01% 🔽)
@sentry/react - Webpack (gzipped) 21.86 KB (-0.01% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.2 KB (-0.01% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.78 KB (-0.01% 🔽)

@Lms24 Lms24 self-assigned this Aug 29, 2023
@Lms24 Lms24 requested review from mydea and lforst August 29, 2023 12:50
@Lms24 Lms24 marked this pull request as ready for review August 29, 2023 12:51
@Lms24 Lms24 changed the title fix(integrations): Mark errors caught from HttpClient integration as unhandled feat(integrations): Mark errors caught from HttpClient integration as unhandled Aug 29, 2023
@Lms24
Copy link
Member Author

Lms24 commented Aug 29, 2023

back to draft, seems like some other integrations are missing

UPDATE: Added CaptureConsole adjustments

@Lms24 Lms24 marked this pull request as draft August 29, 2023 13:22
@Lms24 Lms24 changed the title feat(integrations): Mark errors caught from HttpClient integration as unhandled feat(integrations): Mark errors caught from HttpClient and CaptureConsole integrations as unhandled Aug 29, 2023
@Lms24 Lms24 marked this pull request as ready for review August 29, 2023 15:02
@Lms24 Lms24 force-pushed the lms/fix-handled-unhandled-integrations branch from 3316fad to 9cbd70f Compare September 4, 2023 14:36
@Lms24 Lms24 merged commit 29ef20e into develop Sep 5, 2023
79 checks passed
@Lms24 Lms24 deleted the lms/fix-handled-unhandled-integrations branch September 5, 2023 07:05
@sebammon
Copy link

sebammon commented Oct 4, 2023

@Lms24 once your series of PRs are complete with the changes, it would be great to update the documentation for Sentry - it took me a while to find the reason why the CaptureConsole integration was setting the error as unhandled. I could look into contributing, but I am not too sure of all the areas where these changes where made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants