ref(node-otel): Avoid exporting internals & refactor attribute adding #8920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Aug 31, 2023
| addOtelSpanData(span.spanContext().spanId, { | ||
| origin: 'auto.graphql.otel-graphql', | ||
| }); | ||
| addOriginToOtelSpan(span, 'auto.graphql.otel.graphql'); |
There was a problem hiding this comment.
also noticed some of these have still been incorrectly using - notation, which does not work.
mydea
commented
Aug 31, 2023
| SentrySpan['spanId'], | ||
| SentrySpan | ||
| >(); | ||
| export const SENTRY_SPAN_PROCESSOR_MAP: Map<string, SentrySpan> = new Map<string, SentrySpan>(); |
There was a problem hiding this comment.
Actually the type SentrySpan['spanId'] is not really correct/helpful here, as we are mapping an otel span ID to a sentry Span 🤔
AbhiPrasad
approved these changes
Aug 31, 2023
Lms24
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we kind of extended the public API by exporting some things from opentelemetry-node that we need in node-experimental. I am deprecating these internals as I'm refactoring some things to be a bit cleaner IMHO.
The one export we actually need outside I am exporting as
_INTERNAL_getSentrySpanto make it clear this is not meant to be used otherwise. The main reason I am not just exporting this is that this may have to change if we change how we internally store/handle spans - e.g. if we move away from the map this is just not possible to have anymore, and I do not want to lock us into having to support this in the future.