fix(nextjs): Don't rexport default in route handlers #8924
Merged
+103
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Closed
3 tasks
ted-marozzi
reviewed
Sep 4, 2023
| @@ -58,16 +58,20 @@ function wrapHandler<T>(handler: T, method: 'GET' | 'POST' | 'PUT' | 'PATCH' | ' | |||
| }); | |||
| } | |||
|
|
|||
| // Re-export anything exported by the page module we're wrapping. When processing this code, Rollup is smart enough to | |||
| // not include anything whose name matchs something we've explicitly exported above. | |||
There was a problem hiding this comment.
Just a bystander reading this but maybe you can remove the " above" bit at the end since the comment has moved.
Lms24
approved these changes
Sep 5, 2023
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like Next.js doesn't like it if we export defaults in route handlers: https://github.com/getsentry/sentry-javascript/actions/runs/6031414061/job/16365451995
It appears this is only an error message in dev mode as of now, but we should fix it nonetheless in case it becomes an actual error at some point.
Fixes #8934