Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Bun SDK #9029

Merged
merged 19 commits into from Sep 18, 2023
Merged

feat: Add Bun SDK #9029

merged 19 commits into from Sep 18, 2023

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Sep 14, 2023

  • circularDepCheck is failing for reasons I don't understand - we have the same dep chain in node and doesn't fail there
  • Installing bun in GH actions isn't working

Nice to have:

ref: #7979

Docs: getsentry/sentry-docs#7858
Platform Icon: getsentry/platformicons#102

@HazAT HazAT changed the title feat: Add bun package feat: Add Bun SDK Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 75.56 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 31.49 KB (0%)
@sentry/browser - Webpack (gzipped) 22.09 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 70.25 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 28.59 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 20.66 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 222.11 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 86.64 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 61.49 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 31.47 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 75.58 KB (0%)
@sentry/react - Webpack (gzipped) 22.12 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 93.47 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 51.07 KB (0%)

packages/bun/scripts/install-bun.js Dismissed Show dismissed Hide dismissed
@AbhiPrasad
Copy link
Member

try rebasing re: the circular dep checks - we ran into this in #8933 and fixed it there

Installing bun in GH actions isn't working

Can we try adding a quick bun CLI command to see if there is any output?

- name: Set up Bun
   uses: oven-sh/setup-bun@v1
- name: Test Bun
   run: bun help

@HazAT HazAT marked this pull request as ready for review September 18, 2023 08:09
@timfish
Copy link
Collaborator

timfish commented Sep 18, 2023

we ran into this in #8933 and fixed it there

I only fixed it for @sentry/node

"madge":{
"detectiveOptions": {
"ts": {
"skipTypeImports": true
}
}
},

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass; gonna look at the circular deps issue next...

packages/bun/src/client.ts Outdated Show resolved Hide resolved
packages/bun/src/index.ts Outdated Show resolved Hide resolved
packages/bun/src/sdk.ts Outdated Show resolved Hide resolved
packages/bun/src/types.ts Outdated Show resolved Hide resolved
packages/bun/src/types.ts Outdated Show resolved Hide resolved
packages/bun/README.md Outdated Show resolved Hide resolved
packages/bun/package.json Outdated Show resolved Hide resolved
Comment on lines +22 to +24
"publishConfig": {
"access": "public"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine (no action required) but just to note: With this PR we will not yet publish the Bun SDK because it's not configured in craft.yml. We can tackle this in a follow-up PR!

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
packages/bun/package.json Outdated Show resolved Hide resolved
packages/bun/LICENSE Outdated Show resolved Hide resolved
packages/bun/README.md Show resolved Hide resolved
"@sentry/utils": "7.69.0"
},
"devDependencies": {
"bun-types": "latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how we can say what versions of Bun we support 🤔

Copy link
Member Author

@HazAT HazAT Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't bother too much, let's lock in once we know 😬

packages/bun/src/client.ts Outdated Show resolved Hide resolved
packages/bun/src/client.ts Outdated Show resolved Hide resolved
HazAT and others added 4 commits September 18, 2023 17:53
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@AbhiPrasad
Copy link
Member

Opened #9042 for all follow up tasks after we merge this in

@AbhiPrasad AbhiPrasad merged commit d32b550 into develop Sep 18, 2023
81 checks passed
@AbhiPrasad AbhiPrasad deleted the feat/bun branch September 18, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants