fix(node): fill in span data from http request options object #9112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-zhukov
force-pushed
the
fix/node-span-data-from-http-request-object
branch
from
d78a83f
to
60169cd
Compare
vlad-zhukov
changed the title
vlad-zhukov
force-pushed
the
fix/node-span-data-from-http-request-object
branch
from
60169cd
to
6c4c1d1
Compare
mydea
reviewed
Sep 26, 2023
| @@ -168,6 +168,16 @@ export function normalizeRequestArgs( | |||
| requestOptions = urlToOptions(requestArgs[0]); | |||
| } else { | |||
| requestOptions = requestArgs[0]; | |||
|
|
|||
| if (!requestOptions.pathname || !requestOptions.search) { | |||
| const parsed = new URL( | |||
There was a problem hiding this comment.
Two things:
- Let's try-catch this to ensure this does not fail if we cannot generate an URL there, just to be on the safe side
- Let's instead set the parsed values only if they aren't set.
So something like this:
try {
const parsed = new URL(...);
requestOptions = {
pathname: parsed.pathname,
search: parsed.search,
hash: parsed.hash,
...requestOptions
};
} catch (e) {
// ignore errors here
}
|
Thank you for the PR! That makes sense to me, I left one comment, if you could address this I can merge this in - thanks a lot! |
vlad-zhukov
force-pushed
the
fix/node-span-data-from-http-request-object
branch
from
6c4c1d1
to
4de669b
Compare
|
Thanks @mydea! I've made the changes |
mydea
approved these changes
Sep 27, 2023
|
Thank you for the PR! 🚀 |
c298lee
pushed a commit
that referenced
this pull request
Sep 27, 2023
Currently, span data is missing for Node.js requests created with options object as the only argument, such as `http.request(options)`.
|
This PR was released with https://github.com/getsentry/sentry-javascript/releases/tag/7.73.0. Thanks for your help @vlad-zhukov! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, span data is missing for Node.js requests created with options object as the only argument, such as
http.request(options).