New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix criteria for valid user data #1108
Fix criteria for valid user data #1108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR; please add at least a test and a changelog entry.
@ahaurat after the answer of @kamilogorek in the referenced issue, there is some more work to do, if you are willing to contribute it. We should:
In the next major version considering that none of the attributes of the |
…rname-only # Conflicts: # CHANGELOG.md
@stayallive no problem at all; thanks for tackling it. Apologies I didn't have time to get to it this week. |
Fixes #1107 to allow
username
oremail
to identify a user in addition toid
orip_address
.