Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Frame->absoluteFilePath is always null #1113

Closed
caugner opened this issue Oct 8, 2020 · 3 comments
Closed

v3: Frame->absoluteFilePath is always null #1113

caugner opened this issue Oct 8, 2020 · 3 comments

Comments

@caugner
Copy link

caugner commented Oct 8, 2020

I maintain a legacy app with Smarty templates which causes a lot of Notice noise. We have been filtering these in the before_send callback by comparing the last frame's absolute file path against the directory in which those Smarty templates reside in.

After upgrading to sentry/sdk v3, we noticed that these Notices were no longer filtered.

Debugging showed that all Frame->absoluteFilePaths are now null, which hadn't been the case in v2.

sentry-php/src/Frame.php

Lines 34 to 37 in f09173d

/**
* @var string|null The absolute path to the source file
*/
private $absoluteFilePath;

The Upgrade guide doesn't mention this. Is this a bug or a breaking change?

@caugner
Copy link
Author

caugner commented Oct 8, 2020

Oh, it looks like this bug was already reported in #1103 and fixed in #1104.

@stayallive
Copy link
Collaborator

You are correct, this fix will be released later.

I'll close the issue in the meantime since it was already fixed.

@stayallive
Copy link
Collaborator

3.0.3 was just released fixing this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants