-
Notifications
You must be signed in to change notification settings - Fork 535
Unified naming for span ops #1661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
span op changes don't break anything but transaction op changes are breaking in terms of existing dashboards. |
also is the new consistent span ops table in notion or on develop already? If develop, can you please add the link to the PR description? |
Added link to develop doc to PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look ok, pls don't merge till we decide on roll-out
Note to self: document in the readme all the changes to span ops for everyone that has dashboards it could be breaking. |
Maybe we can find out how many dashboards would be affected with this change. Possible ways to go: |
The definite guide of changed span/transaction
|
Made a draft again so we do not accidentally merge it. Also related to this one #1665 |
…try/sentry-python into antonpirker/1643-unified-span-ops
Having a unified naming for span ops helps the performance team to discover performance issues.
The ops in the tests are all hard coded, so the tests show if someone trying to change ops string.
A list of all available span ops can be found in the develop docs:
https://develop.sentry.dev/sdk/performance/span-operations/
Fixes #1643