Include framework in SDK name #1662
Merged
+119
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
requested changes
Oct 5, 2022
|
I did not make the var lower case although it is no real const anymore but having it uppercase just shows me that it is defined somewhere on the top (and not given as a parameter) |
…:getsentry/sentry-python into antonpirker/1497-sdk-name-with-framework
sl0thentr0py
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Python sdk reports always the name
sentry.pythonas its name. For consistent sdk naming and better data analysis of events we want to have also include the framework in the SDK name. Likesentry.python.django.Fixes #1497