Asyncio fixes #1689
Merged
Asyncio fixes #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
antonpirker
commented
Oct 18, 2022
antonpirker
commented
- Fix task creation (give the coroutine object, not the function creating it)
- Make sure a user set task factory is not overridden by our factory.
…y/sentry-python into antonpirker/asyncio-integration
Co-authored-by: Neel Shah <neelshah.sa@gmail.com>
Co-authored-by: Neel Shah <neelshah.sa@gmail.com>
Merged
|
I will create a new PR for the exception handling. Please approve this @sl0thentr0py (if it is ok) so we can merge it. |
sl0thentr0py
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.