Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integrations): Fix http putrequest when url is None #1693

Merged
merged 1 commit into from Oct 20, 2022
Merged

fix(integrations): Fix http putrequest when url is None #1693

merged 1 commit into from Oct 20, 2022

Conversation

MattFlower
Copy link
Contributor

Modifies behavior of putrequest to check for None on real_url prior to using it.

Fixes GH-1678

fix(integrations): Fix http putrequest when url is None
20dcf7e 
Modifies behavior of putrequest to check for None on real_url prior to using it.

Fixes getsentryGH-1678
@antonpirker
Copy link
Member

Hey @MattFlower,
great work! Thanks for contributing.

@antonpirker antonpirker enabled auto-merge (squash) October 20, 2022 07:24
@antonpirker antonpirker merged commit c471331 into getsentry:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry's http putrequest override breaks if url is None, while native http does not
2 participants
@MattFlower @antonpirker