Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handling to Asyncio Integration #1695

Merged
merged 32 commits into from Oct 20, 2022

Conversation

antonpirker
Copy link
Member

@antonpirker antonpirker commented Oct 20, 2022

Make sure that we also capture exceptions from spawned async Tasks.

Refs #1690

antonpirker and others added 29 commits October 10, 2022 11:34
…y/sentry-python into antonpirker/asyncio-integration
Co-authored-by: Neel Shah <neelshah.sa@gmail.com>
Co-authored-by: Neel Shah <neelshah.sa@gmail.com>
@antonpirker antonpirker marked this pull request as ready for review October 20, 2022 08:22
@antonpirker
Copy link
Member Author

This is code on top of #1689

@sl0thentr0py sl0thentr0py changed the base branch from master to antonpirker/asyncio-integration October 20, 2022 11:03
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one test for exceptions please :)

Base automatically changed from antonpirker/asyncio-integration to master October 20, 2022 11:43
@antonpirker antonpirker merged commit 29431f6 into master Oct 20, 2022
@antonpirker antonpirker deleted the antonpirker/asyncio-exceptions branch October 20, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants