Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix pytest error #2712

Merged
merged 2 commits into from Feb 6, 2024
Merged

test: Fix pytest error #2712

merged 2 commits into from Feb 6, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Feb 6, 2024 •
edited

The ability to pass None to pytest.capture_warnings was removed in pytest version 8.0.0. To validate that this fix, one can run any of the test cases with pytest==8.0.0. Without this change, the test immediately fails with an error; with the change, the test suite runs as expected.

Fixes GH-2693

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) February 6, 2024 16:10
sentrivana
sentrivana approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@szokeasaurusrex szokeasaurusrex mentioned this pull request Feb 6, 2024
Closed
@szokeasaurusrex szokeasaurusrex merged commit d97e7d7 into master Feb 6, 2024
121 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/fix-pytest branch February 6, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.40.0: pytest fails with deprecation errors
2 participants
@szokeasaurusrex @sentrivana