Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clickhouse): Support clickhouse-driver==0.2.7 #2752

Merged
merged 1 commit into from Feb 21, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Feb 21, 2024

Release 0.2.7 of clickhouse-driver treats insert queries differently than before, leading to us not capturing breadcrumbs for them anymore. We need to wrap the newly introduced receive_end_of_insert_query just like we do receive_end_of_query.


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review February 21, 2024 10:10
@sentrivana sentrivana enabled auto-merge (squash) February 21, 2024 10:13
@sentrivana sentrivana merged commit e07c0ac into master Feb 21, 2024
122 of 123 checks passed
@sentrivana sentrivana deleted the ivana/pin-clickhouse branch February 21, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants