fix(metrics): Fix metrics compatibility with greenlet/gevent
#2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
changed the title
greenlet/gevent
sentrivana
commented
Feb 22, 2024
Comment on lines
-250
to
-255
| # See http://www.gevent.org/install.html#older-versions-of-python | ||
| # for justification of the versions pinned below | ||
| py3.5-gevent: gevent==20.9.0 | ||
| # See https://stackoverflow.com/questions/51496550/runtime-warning-greenlet-greenlet-size-changed | ||
| # for justification why greenlet is pinned here | ||
| py3.5-gevent: greenlet==0.4.17 |
There was a problem hiding this comment.
We don't actually run py3.5-gevent so we don't need this
sentrivana
changed the title
greenlet/geventgreenlet/gevent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make metrics work with
gevent(again) and play nicely with the rest of the SDK.gevent-patchedthreading.Eventinstead of the original unpatched one to avoid greenlets waiting on the event blocking executionthreading.Thread) instead of a native thread for the flushergeventis used due to broken context varsMixing thread-based and greenlet-based primitives might lead to deadlocks in apps running in
geventmode.Likely fixes #2748
General Notes
Thank you for contributing to
sentry-python!Please add tests to validate your changes, and lint your code using
tox -e linters.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secretslabel. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.