Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): allow empty character in metric tags values #2775

Merged
merged 3 commits into from Feb 28, 2024
Merged

fix(docs): allow empty character in metric tags values #2775

merged 3 commits into from Feb 28, 2024

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Feb 28, 2024

markushi
markushi approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markushi markushi mentioned this pull request Feb 28, 2024
Merged
7 tasks
@sentrivana
Copy link
Contributor

@viglia LGTM but can we please also test for this in this testcase?

sentrivana
sentrivana reviewed Feb 28, 2024
View reviewed changes
tests/test_metrics.py Outdated Show resolved Hide resolved
sentrivana
sentrivana approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viglia, left a suggestion that should make the CI green, feel free to merge once addressed.

@viglia viglia merged commit e07a128 into master Feb 28, 2024
123 checks passed
@viglia viglia deleted the viglia/fix/allow-empty-char-in-tag-values branch February 28, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markushi markushi markushi approved these changes

@sentrivana sentrivana sentrivana approved these changes

@Dav1dde Dav1dde Awaiting requested review from Dav1dde

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viglia @sentrivana @markushi