Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(awslambda): xfail broken tests for now #2794

Merged
merged 2 commits into from Mar 7, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 7, 2024

We rely on the log output of our AWS Lambda tests to determine whether the tests have been successful: we log envelope and event contents and then check whether the log output looks as expected.

AWS Lambda has recently started logging a new warning when a function throws an unhandled exception. This is a scenario we're testing in some of our test cases.

The problem is that the log output is limited to the last 4kB and the new warning takes up a lot of space, so some of our events/envelopes will not fit anymore.

xfailing the tests here so that our release is not blocked now, but we'll need a proper solution, see #2795


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review March 7, 2024 13:14
@sentrivana sentrivana enabled auto-merge (squash) March 7, 2024 13:16
@sentrivana sentrivana merged commit 8f1a125 into master Mar 7, 2024
123 checks passed
@sentrivana sentrivana deleted the ivana/skip-failing-aws-lambda-tests branch March 7, 2024 13:25
@antonpirker
Copy link
Member

As a follow on fixing this issue for real we have created this GH Issue: #2795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants