-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Quart] sentry_patched_asgi_app() missing 1 required positional argument: 'send' #3040
Comments
I resolved this by rolling back to version 1. Is there a way this can fail gracefully in the future or raise an "This is an issue with the Sentry SDK" type error message as it was only after rolling back our app and all changes I realised it was Sentry, from the error I assumed a request being passed to sentry was malformed. |
Thanks for the issue report. This indeed appears to be a regression – I was able to reproduce the error here (although I received 500 status codes, not 404 as stated in this issue). But, the error message is the same. |
The Quart integration was completely broken prior to this commit, as it caused every request to fail with a 500 error. The reason was that we were using the non-async `ensure_integration_enabled` decorator on the async `sentry_patched_asgi_app` function. This commit fixes the issue by removing the use of that decorator, instead replacing it with a manual check for the integration being enabled. Fixes GH-3040
Hey @KingsleyKelly, so we have a fix (#3043) for this issue already. We plan to release the fix on Monday (May 6) in the morning (CET). Until then, please use version 1.x to work around this issue. We apologize for any inconvenience caused by this bug. |
@KingsleyKelly We just released version 2.1.0, which should fix this problem! |
Thanks @szokeasaurusrex I will give it a test tomorrow also. |
Tested with both Quart and QuartTrio - all working well. Thanks for the quick fix. |
How do you use Sentry?
Sentry Saas (sentry.io)
Version
latest
Steps to Reproduce
Requirements
Note that sentry, hypercorn and quart arent locked.
With the following invocation
It gives the following error
Expected Result
We can use Sentry
Actual Result
App 404s all requests
The text was updated successfully, but these errors were encountered: