Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2 (GA Performance with auto instrumentation) #1272

Closed
11 of 14 tasks
bruno-garcia opened this issue Jan 5, 2021 · 8 comments
Closed
11 of 14 tasks

Release 2.2 (GA Performance with auto instrumentation) #1272

bruno-garcia opened this issue Jan 5, 2021 · 8 comments

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Jan 5, 2021

This issue will track the release of v2.2 with auto instrumentation of React Navigation v4, v5, fetch/xhr and react profiler.

@bruno-garcia bruno-garcia added this to Backlog in Mobile Platform Team Archived via automation Jan 5, 2021
@bruno-garcia bruno-garcia moved this from Backlog to In Progress in Mobile Platform Team Archived Jan 5, 2021
@marandaneto
Copy link
Contributor

I'd say we could go ahead without #1291 and iterate later

@marandaneto
Copy link
Contributor

@jennmueng mind explaining what's the issue with the beforeNavigate? not sure what this is about

@jennmueng
Copy link
Member

@marandaneto beforeNavigate (to be passed to the ReactNativeTracing integration) currently wasn't used in RN due to the limitation with the V5 instrumentation but I found a workaround that allows it to be used. This way we match the API on JS and get rid of the redundant shouldSendTransaction option passed to the instrumentation.

@marandaneto
Copy link
Contributor

@jennmueng cool thanks, should we create its own issue for that. so we could track it down and link to the PR? this also would require docs?

@PeloWriter
Copy link

Yes, please, on the Docs. Here's the WIP for Performance Docs - getsentry/sentry-docs#2970

@marandaneto
Copy link
Contributor

@jennmueng cool thanks, should we create its own issue for that. so we could track it down and link to the PR? this also would require docs?

@jennmueng I guess this issue is ready to be closed, do we need to update docs?

@jennmueng
Copy link
Member

@marandaneto Yes we need docs

@marandaneto
Copy link
Contributor

marandaneto commented Feb 2, 2021

ok now we have its own issue for docs getsentry/sentry-docs#2995 and we can close this issue

Mobile Platform Team Archived automation moved this from In Progress to Done Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants