-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Huge freezes/lags when using automatic instrumentation with react-navigation & expo #3796
Comments
Hi @yonitou, Would you be able to reproduce this in an example app or share a link to some recorded sentry profiles for us to inspect. |
I tried the following :
|
Thanks for testing and the link @yonitou! We'll need to investigate and follow up here |
Thanks a lot :) waiting for your feedbacks. I hope my profiling link will help. |
Hi @yonitou, To narrow down what is causing the freezes/lags, could you try to disable some of the tracing features? new Sentry.ReactNativeTracing({
routingInstrumentation,
enableStallTracking: false,
}) Could you also share how you measure the freezes or do you observe them when testing the application? |
Hi @krystofwoldrich The first one is WITHOUT the instrumentation. You can see that it's quite smooth (the development build is never as smooth as a production one in my case) and the switch between tabs is almost instantaneous and the feedback is immediate This one is WITH the instrumentation on ! Look at those freezes. You can't see it (because the screen recording doesn't show my finger taps) but when you see me waiting on a screen, it's because I'm trying to navigate through my tabs but I don't have any feedback, the app is completely stuck and then, getting unstuck at some point.. Does it help ? |
Hi @yonitou, From the second video the JS thread is pinned to 60 FPS which is suspicious since the other video show dropping frame rate. Do you observe anything in the JS Console logs during the freeze? Is there any Sentry log just before/after the freeze? Or the console doesn't freeze? Would you be able to reproduce this in a sample app that you could share with us, so we can debug it? |
Hey
Does it help ? |
Thank you @yonitou, Could you try to disable it to confirm the theory. new Sentry.ReactNativeTracing({
routingInstrumentation,
enableNativeFramesTracking: false,
}) |
Not changing anything :/ I just made a new test to isolate the freezing logs. Here's the result :
|
@yonitou Thank you for the log, this would point to the profile creation, does it consistently freeze at the same place in the logs? Where does it freeze without profiling? When disabling profiling, remove the option |
Hi, I made another test with BUT I think I understood something : if I'm waiting for the log |
Hi, |
Platform:
SDK:
@sentry/react-native
(>= 1.0.0)react-native-sentry
(<= 0.43.2)SDK version: 5.19.1
react-native
version: 0.73.4Are you using Expo?
Are you using sentry.io or on-premise?
If you are using sentry.io, please post a link to your issue so we can take a look:
Hard to send a link since it's related to freezes and slow performances
Configuration:
(
@sentry/react-native
)I have the following issue:
When I add the integration
Sentry.ReactNativeTracing
with the routing instrumentation for react navigation with the setup above (you will notice that myref
is not created usinguseRef
but withcreateNavigationContainerRef
fromreact-navigation
because I need it for other things in my app), things start to be very slow and I'm experiencing huge freezes when navigating across my screens especially when I'm navigation through my tabs.Actual result:
Expected result:
The text was updated successfully, but these errors were encountered: