fix: Avoid Deadlock popping ScopeGuards out of order #536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ScopeGuard
panics when it is being dropped out of order. Previously it would do so while holding the Scope/stackRwLock
. ThePanicIntegration
would also try to acquire that same lock in order to capture the resulting panic, resulting in a deadlock or a double-panic in case theRwLock
implementation detected the deadlock.