Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper Transport #550

Open
kvnvelasco opened this issue Feb 7, 2023 · 3 comments
Open

Hyper Transport #550

kvnvelasco opened this issue Feb 7, 2023 · 3 comments

Comments

@kvnvelasco
Copy link
Contributor

kvnvelasco commented Feb 7, 2023

Reqwest adds quite a bit of time to compile times in projects where it isn't needed. Removing reqwest from our project reduced compile times by about 30s. We already have hyper in the dependency tree via axum so it was mostly free.

Willing to put up an implementation of this if it's supported.

@Swatinem
Copy link
Member

Swatinem commented Feb 7, 2023

I believe this is a good idea, yes.
What exactly would be the advantages feature wise? As reqwest is based on hyper itself, but I assume you have to implement a ton of stuff yourself.

@kvnvelasco
Copy link
Contributor Author

It would definitely be a feature reduction actually. Proxy support is something that we've intentionally left out of scope (because we don't use one). The reduction in feature scope reduces compile times and we find the trade off advantageous in that way.

@fenollp
Copy link
Contributor

fenollp commented Apr 5, 2024

@kvnvelasco Is your code on a public branch somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants