build(backtrace): Disable most of default regex features #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KamilaBorowska
force-pushed
the
disable-most-default-regex-features
branch
from
42b1c48
to
352a250
Compare
The regex crate used by Sentry doesn't need full Unicode tables, just the ones used by \w, \s, \d and \b.
KamilaBorowska
force-pushed
the
disable-most-default-regex-features
branch
from
352a250
to
9c9df73
Compare
KamilaBorowska
changed the title
KamilaBorowska
changed the title
loewenheim
approved these changes
Feb 13, 2023
Swatinem
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regex as used by Sentry doesn't need full Unicode tables, just ones used by
\w,\s,\dand\b(unicode-perlfeature). This reduces size of the binary.