ci: Set default rust toolchain to MSRV for MSRV job #555
Conversation
| @@ -15,7 +15,7 @@ jobs: | |||
| - name: Checkout sources | |||
| uses: actions/checkout@v3 | |||
|
|
|||
| - run: rustup toolchain install stable --profile minimal --component rustfmt --component clippy --no-self-update | |||
There was a problem hiding this comment.
We want the latest stable version whenever that is available. We don’t want to be at the mercy of whenever github feels like updating their Runners.
There was a problem hiding this comment.
They have weekly cadence though, so not sure if it's that crucial tbh.
If we want to update it though, we'll need to change the default everywhere as well, as it's tied to version installed in the image.
| runs-on: ${{ matrix.os }} | ||
|
|
||
| env: | ||
| RUSTFLAGS: -Dwarnings |
There was a problem hiding this comment.
While it sure is a pain that we have failing builds on every Rust update, that is quite intentional and we do want to deny warnings.
There was a problem hiding this comment.
setting RUSTFLAGS: -Dwarnings is redundant, as all make jobs that are used already set it there
There was a problem hiding this comment.
We do have a few steps that are not using the makefile targets
There was a problem hiding this comment.
Iiiii don't belive so? I removed it from workflows that run make checkall, make checkfastandmake testfast. All of which already set -Dwarnings. (make testfaildoesnt but in this casecheckfast` would fail first)
rustup toolchain install stablecalls are redundant due toubuntu-latestalready containins up-to-date stable - https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md#rust-toolsRUSTFLAGS: -Dwarningsis redundant, as allmakejobs that are used already set it therecomponent addusesstableby defaultrustup default ${{ matrix.rust }}for MSRV tests is required, as otherwisestableis used