Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add biome rules for strict tests #69528

Merged
merged 1 commit into from
May 16, 2024
Merged

feat: add biome rules for strict tests #69528

merged 1 commit into from
May 16, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 23, 2024

Adds biome rules specifically for Jest.

@anonrig anonrig requested review from a team as code owners April 23, 2024 19:43
@anonrig anonrig enabled auto-merge (squash) April 23, 2024 19:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 23, 2024
@anonrig anonrig force-pushed the anonrig/add-biome-test-rules branch from f74ff27 to 1894df6 Compare April 23, 2024 19:48
@codecov Codecov
Copy link

codecov bot commented Apr 23, 2024 •
edited

Bundle Report

Changes will increase total bundle size by 5.3kB ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 26.34MB 5.3kB ⬆️

@anonrig anonrig force-pushed the anonrig/add-biome-test-rules branch from f12f705 to 51b16df Compare April 23, 2024 20:10
@anonrig anonrig force-pushed the anonrig/add-biome-test-rules branch from 51b16df to 8fefeed Compare April 23, 2024 20:34
scttcper
scttcper approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@scttcper scttcper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malwilley is making a new search bar anyway

@getsantry
Copy link
Contributor

getsantry bot commented May 15, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label May 15, 2024
@anonrig anonrig force-pushed the anonrig/add-biome-test-rules branch from 8fefeed to 8cc6392 Compare May 16, 2024 20:50
@anonrig anonrig requested a review from a team as a code owner May 16, 2024 20:50
@anonrig anonrig disabled auto-merge May 16, 2024 20:50
@anonrig anonrig removed the Stale label May 16, 2024
@anonrig anonrig enabled auto-merge (squash) May 16, 2024 21:02
@anonrig anonrig merged commit 66c45a6 into master May 16, 2024
42 checks passed
@anonrig anonrig deleted the anonrig/add-biome-test-rules branch May 16, 2024 21:02
cmanallen pushed a commit that referenced this pull request May 21, 2024
@anonrig @cmanallen
feat: add biome rules for strict tests (#69528)
d592fed 
Adds biome rules specifically for Jest.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scttcper scttcper scttcper approved these changes

@evanpurkhiser evanpurkhiser evanpurkhiser approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anonrig @scttcper @evanpurkhiser