Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update query-string module #69553

Closed
wants to merge 1 commit into from
Closed

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 23, 2024

Updates query-string module to latest version which has proper typescript support.

@anonrig anonrig requested review from a team as code owners April 23, 2024 23:11
@anonrig anonrig force-pushed the anonrig/update-query-string branch from 305f6a8 to f4d80c4 Compare April 23, 2024 23:12
@anonrig anonrig changed the title Anonrig/update query string chore: update query-string module Apr 23, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 23, 2024
@anonrig anonrig force-pushed the anonrig/update-query-string branch from f4d80c4 to 8589928 Compare April 24, 2024 00:06
@anonrig anonrig requested a review from a team as a code owner April 24, 2024 00:06
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (7323263) to head (f4d80c4).
Report is 16 commits behind head on master.

❗ Current head f4d80c4 differs from pull request most recent head 8589928. Consider uploading reports for the commit 8589928 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #69553       +/-   ##
===========================================
- Coverage   79.65%   56.03%   -23.62%     
===========================================
  Files        6483     6482        -1     
  Lines      287824   287891       +67     
  Branches    49599    49634       +35     
===========================================
- Hits       229270   161330    -67940     
- Misses      58182   126560    +68378     
+ Partials      372        1      -371     
Files Coverage Δ
static/app/actionCreators/pageFilters.tsx 0.00% <ø> (-84.34%) ⬇️
static/app/api.tsx 0.00% <ø> (-33.34%) ⬇️
static/app/bootstrap/initializeLocale.tsx 0.00% <ø> (ø)
static/app/components/avatar/baseAvatar.tsx 0.00% <ø> (-100.00%) ⬇️
static/app/components/avatar/gravatar.tsx 0.00% <ø> (-75.00%) ⬇️
static/app/components/charts/chartZoom.tsx 0.00% <ø> (-34.85%) ⬇️
...pp/components/events/eventTags/eventTagContent.tsx 0.00% <ø> (-100.00%) ⬇️
...p/components/events/eventTags/eventTagsTreeRow.tsx 0.00% <ø> (-73.78%) ⬇️
...ts/interfaces/spans/newTraceDetailsSpanDetails.tsx 0.00% <ø> (-10.89%) ⬇️
static/app/components/events/interfaces/utils.tsx 0.00% <ø> (-71.28%) ⬇️
... and 56 more

... and 2993 files with indirect coverage changes

Comment on lines +206 to +211
const ESM_NODE_MODULES = [
'query-string',
'decode-uri-component',
'split-on-first',
'filter-obj',
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☹️

@getsantry
Copy link
Contributor

getsantry bot commented May 15, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label May 15, 2024
@getsantry getsantry bot closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants