Failing Make Install (wrong test inputs)

[RishabhBhatnagar]

make install is failing due to failing test of sops/config/config_test.go. Lines 375 and 379 of the TestLoadConfigFileWithVaultDestinationRules are erroneous.

The test expects the output of conf.Destination.Path to have an http protocol but the function returns the output URL with https protocol which is causing the tests to fail.

[autrilla]

This has indeed been broken for ages :( #576 attempted to fix it. For now, you can set the VAULT_ADDR env var to http://127.0.0.1:8200 to solve it.

[RishabhBhatnagar]

Both the lines (375, 379) uses a config file with vault destination rules. If any URL is not specified, the VaultDestination.Path method of publish/vault.go uses a base URL supplied by getAddress() method of "github.com/hashicorp/vault/api" library which returns a base address with protocol of https.

For a quick fix, I've updated the tests to use https instead of http.

[RishabhBhatnagar]

This has indeed been broken for ages :( #576 attempted to fix it. For now, you can set the VAULT_ADDR env var to http://127.0.0.1:8200 to solve it.

As I can see, #576 is associated with other things as well. Are we expecting that PR to be merged soon or should I create a new PR for fixing the current issue?

[autrilla]

I don't think that PR is going to be merged any time soon, so it would be great if you create a new PR for fixing the issue.

[ajvb]

Fixed with #731