Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

max_retries more like max_tries in useragent #40

Closed
x00 opened this issue Mar 28, 2014 · 2 comments
Closed

max_retries more like max_tries in useragent #40

x00 opened this issue Mar 28, 2014 · 2 comments
Milestone

Comments

@x00
Copy link

x00 commented Mar 28, 2014

No biggie.

To me a retry is something you do after trying once. So retry once is not the same as try once.

see here

https://github.com/gwik/geventhttpclient/blob/master/src/geventhttpclient/useragent.py#L313

if max_retries=0 you will up here:

return self._handle_retries_exceeded(url, last_error=e)

and e hasn't been declared.

Btw great project!

@x00
Copy link
Author

x00 commented Mar 28, 2014

same for max_redirects

@gwik gwik added this to the 1.1 release milestone Apr 7, 2014
@ml31415
Copy link
Collaborator

ml31415 commented Apr 18, 2014

Yes, you're right, my naming was a bit misleading.

@gwik gwik modified the milestones: v1.2 release, 1.1 release Oct 21, 2014
@ml31415 ml31415 modified the milestones: v1.5 release, 2.3 release Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants