Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageFormat::Rgb10a2ui uses inconsistent casing. #192

Open
XAMPPRocky opened this issue Apr 22, 2021 · 4 comments
Open

ImageFormat::Rgb10a2ui uses inconsistent casing. #192

XAMPPRocky opened this issue Apr 22, 2021 · 4 comments

Comments

@XAMPPRocky
Copy link
Contributor

Notice how ImageFormat::Rgb10A2 and ImageFormat::Rgb10a2ui have a differently cased A, in Rust the casing starts at the beginning of each word. The former is correct and Rgb10a2ui should be Rgb10A2ui .

@XAMPPRocky XAMPPRocky changed the title ImageFormat::Rgb10a2ui use inconsistent casing. ImageFormat::Rgb10a2ui uses inconsistent casing. Apr 22, 2021
@MarijnS95
Copy link
Collaborator

By the way, shouldn't the U in Ui be capitalized as well?

@XAMPPRocky
Copy link
Contributor Author

XAMPPRocky commented Apr 22, 2021

By the way, shouldn't the U in Ui be capitalized as well?

Good question, I don't think so based on how these formats are cased in GLSL, you can see it's specified as rgb10_a2 and rgb10_a2ui, which to me would imply that you're supposed to treat a2 and a2ui as whole words.

https://www.khronos.org/opengl/wiki/Image_Load_Store

@MarijnS95
Copy link
Collaborator

Hmm, complicated. @XAMPPRocky are we looking at this from a Rust naming conventions or GLSL/SPIR-V naming perspective? That link implies the entire thing to be lowercase while the autogenerator here seems to take the grammar name verbatim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants