Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE files in package subdirs #230

Open
schwa423 opened this issue Mar 28, 2022 · 3 comments
Open

LICENSE files in package subdirs #230

schwa423 opened this issue Mar 28, 2022 · 3 comments

Comments

@schwa423
Copy link

schwa423 commented Mar 28, 2022

Background:

Hello, the Fuchsia project vendors crates from crates.io, and in order to do so we require explicit license files alongside the source code. Here is the policy: https://fuchsia.dev/fuchsia-src/contribute/governance/policy/open-source-licensing-policies?hl=en#licenses_and_tracking . In particular, reading the SPDX package/license field from the crate's Cargo.toml is not good enough.

Request:

Could you please add LICENSE-* files to the package subdirectories, specifically spirv/ (although you might as well do it for all package dirs that are uploaded to crates.io)?

We are currently using spirv 0.2.0+1.5.4. Since crates.io doesn't allow re-uploading the same version with a modified crate, it seems the right thing to do is to upload new a new crate with version, ummm..., I dunno: 0.2.1+1.5.5? I'm a bit confused by the naming scheme.

I'd appreciate if you're able to do this, since I have to file similar issues for many other crate dependencies. But if you don't have the bandwidth to address this issue, please let me know and I'll find time to submit a pull request (although of course I won't be able to upload anything to crates.io)

@MarijnS95
Copy link
Collaborator

The + encodes version metadata, in this case SPIR-V standard version 1.5.4 that the spirv crate was generated from.

@schwa423
Copy link
Author

Thanks for explaining. That being the case, I should have suggested 0.2.1+1.5.4 for the new crate version.

@schwa423
Copy link
Author

BTW, I edited the issue description with a link to our licensing policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants