Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): move SortableJS as dev deps #1407

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

ghiscoding
Copy link
Owner

  • SortableJS is already required by Slickgrid-Universal and is only used by Jest in Angular-Slickgrid, so it should be moved to dev deps for that reason.

- SortableJS is already required by Slickgrid-Universal and is only used by Jest in Angular-Slickgrid, so it should be moved to dev deps for that reason.
Copy link

stackblitz bot commented May 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9fde237) to head (41113b7).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1407   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          905       905           
  Branches       299       295    -4     
=========================================
  Hits           905       905           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 781c164 into master May 14, 2024
4 checks passed
@ghiscoding ghiscoding deleted the chore/sortable-dev-deps branch May 14, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants