Fix eslint configuration

[dtslvr]

Running yarn lint exits with the following error:

Linting "api"...

NX ESLint configuration in apps/api/.eslintrc.json » ../../.eslintrc.json is invalid:

    - Property "extends" is the wrong type (expected string but got `[null,"plugin:storybook/recommended"]`).
    - Property "extends[0]" is the wrong type (expected string but got `null`).
    - "extends" should match exactly one schema in oneOf. Value: [null,"plugin:storybook/recommended"].

Referenced from: /home/fares/repo/_projects/ghostfolio/apps/api/.eslintrc.json
Pass --verbose to see the stacktrace.

NX Ran target lint for project api (613ms)

✖    1/1 failed
✔    0/1 succeeded [0 read from cache]

View structured, searchable error logs at https://nx.app/runs/SDeoEU7RfZ

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Originally posted by @underwater in #2772 (reply in thread)

[underwater]

@dtslvr you can assign it to me, and I will dig into this right after we close the p/r on permissions

[underwater]

@dtslvr
I suspect, updating the .eslintrc.json file to use
"extends": ["plugin:storybook/recommended"]
instead of
"extends": [null, "plugin:storybook/recommended"]

would likely resolve the .eslintrc.json is invalid error but the linting itself would raise a large number of errors / warnings (mostly relating to circular dependencies and suggestions for using relative paths for internal imports.....

I did rollback locally to various older commit points to check last occurence when linting worked, but it seems linting always generated errors.... Is the script yarn lint being actively used during local development or triggered in CI / CD ?

[dtslvr]

Linting has not been used at this point, but I think it would be an improvement. To get to this point, I suggest that we resolve the circular dependencies and temporarily deactivate the rule with the relative paths imports.

"extends": ["plugin:storybook/recommended"]

Good discovery! Can you create a PR for this change?

[underwater]

Yes, sure, I return in a few days, and will have a look - B wishes for end of year holidays ;-)

…

On Thu, 28 Dec 2023 at 09:53, Thomas Kaul ***@***.***> wrote: Linting has not been used at this point, but I think it would be an improvement. To get to this point, I suggest that we resolve the circular dependencies and temporarily deactivate the rule with the relative paths imports. "extends": ["plugin:storybook/recommended"] Good discovery! Can you create a PR for this change? — Reply to this email directly, view it on GitHub <#2782 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN4N6ZIYLEEIGL5JAJSHPDYLUXPRAVCNFSM6AAAAABBCG4JNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZQHE2TGMJXGQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

[underwater]

@dtslvr I am sorry but again due to health will be offline for another 10 days, and suggest perhaps un-assign me this issue, for better visibility,.....

[dtslvr]

@underwater No problem. Get well soon!