Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] opening menu items in a new tab redirects to /en/start instead of the expected route #3257

Open
nlighteneddesign opened this issue Apr 8, 2024 · 8 comments
Labels
question Further information is requested

Comments

@nlighteneddesign
Copy link

Bug Description
Opening a link in a new tab brings me to the start page rather than opening a new tab on the page I middle clicked on.

To Reproduce

  1. Log into the site.
  2. Go to portfolio
  3. Middle click on accounts to open a new tab on the accounts page

Expected behavior
The accounts page would be open in a new tab

Screenshots
N/A

Logs
N/A

Environment

  • Ghostfolio Version 2.70.0
  • Self-hosted Docker
  • Experimental Features disabled ( I did not manually enable anything )
  • Browser Firefox
  • OS Ubuntu 22.04

Additional context
N/A

@dtslvr
Copy link
Member

dtslvr commented Apr 9, 2024

Hi @nlighteneddesign

Can you please clarify what you mean by "Go to portfolio" → "Middle click on accounts"? When I middle click on Accounts in the navigation bar, it opens a new tab.

Please use a descriptive title. Thank you.

@dtslvr dtslvr added the question Further information is requested label Apr 9, 2024
@nlighteneddesign
Copy link
Author

Sorry about the title, I must have skipped past it.
What I mean is when you're logged in clicking on menu items works as expected, e.g. clicking on portfolio you see the performance.

Once there if I middle click the accounts menu item, instead of opening accounts in a new tab I am brought here: /en/start and I have to log in again on that tab.
The original tab is still logged in.
If I then just click on the accounts menu item in the original tab I see /en/accounts as expected.

@nlighteneddesign nlighteneddesign changed the title [BUG] [BUG] opening menu items in a new tab redirects to /en/start instead of the expected route Apr 9, 2024
@nlighteneddesign
Copy link
Author

Right clicking and opening as a new tab has the same behavior

@nlighteneddesign
Copy link
Author

Investigating further not all menu items act the same:

Overview, Accounts, and Admin Control all land you on /en/start

Portfolio lands you on /en/portfolio, but nothing populates and you have the sign in (see screenshot) Screenshot 2024-04-09 at 09-11-16 Ghostfolio – Open Source Wealth Management Software

Resources and About show you the expected page with a login part.

@nlighteneddesign
Copy link
Author

Console logs show a few instances of: ERROR TypeError: r.user is undefined

It seems that the auth token is being stripped when opening in a new tab for some reason.

@dtslvr
Copy link
Member

dtslvr commented Apr 9, 2024

I cannot reproduce it in Google Chrome / Safari. Maybe it is a Firefox related issue?

@nlighteneddesign
Copy link
Author

More likely Linux since it happens to me on both Chrome and Firefox.

@dtslvr
Copy link
Member

dtslvr commented Apr 9, 2024

More likely Linux since it happens to me on both Chrome and Firefox.

Could you set up the development environment and analyze locally why ERROR TypeError: r.user is undefined is thrown?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants