Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: giggio/node-chromedriver
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 116.0.0
Choose a base ref
...
head repository: giggio/node-chromedriver
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 117.0.0
Choose a head ref
  • 4 commits
  • 6 files changed
  • 1 contributor

Commits on Sep 19, 2023

  1. Bump version to 117.0.0

    @giggio
    giggio committed Sep 19, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    anbotero Andrés Botero
    GPG key ID: D80066A541EE1A58
    Verified
    Learn about vigilant mode
    Copy the full SHA
    0bb2212 View commit details

  2. Remove Node.js 16 

    Node.js 16 is no longer supported.
See https://nodejs.dev/en/about/releases/ for
more information
    @giggio
    giggio committed Sep 19, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    203e50c View commit details

  3. Update uraimo/run-on-arch-action

    @giggio
    giggio committed Sep 19, 2023

    Verified

    This commit was signed with the committer’s verified signature.
    stefanprodan Stefan Prodan
    GPG key ID: 3299AEB0E4085BAF
    Verified
    Learn about vigilant mode
    Copy the full SHA
    1ddef09 View commit details

  4. Remove install npm latest from build for arm 

    Build is breaking, probably a problem of npm 10
with node 18
    @giggio
    giggio committed Sep 19, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    91065a6 View commit details
Showing with 88 additions and 73 deletions.
  1. +1 −1 .devcontainer/Dockerfile
  2. +6 −7 .github/workflows/build.yml
  3. +1 −1 lib/chromedriver.js
  4. +77 −61 package-lock.json
  5. +2 −2 package.json
  6. +1 −1 testInstall.js
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
View file
Original file line number Diff line number Diff line change
@@ -14,6 +14,6 @@ RUN echo $USERNAME ALL=\(root\) NOPASSWD:ALL > /etc/sudoers.d/$USERNAME \
&& chmod 0440 /etc/sudoers.d/$USERNAME
USER $USERNAME
RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.2/install.sh | bash
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 16.20.0 && nvm i --no-progress 18.16.0 && nvm i --no-progress 20.2.0" ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm i --no-progress 18.18.0 && nvm i --no-progress 20.7.0" ]
RUN [ "/bin/bash", "-c", "source $HOME/.nvm/nvm.sh && nvm alias default 20" ]
ENV DEBIAN_FRONTEND=dialog
13 changes: 6 additions & 7 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["16.x", "18.x", "20.x"]
node: ["18.x", "20.x"]
runner: ["windows-latest", "ubuntu-latest", "macos-latest"]
steps:
- uses: actions/checkout@v2
@@ -71,10 +71,10 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ["16", "18", "20"]
node: ["18", "20"]
steps:
- uses: actions/checkout@v2
- uses: uraimo/run-on-arch-action@v2.1.1
- uses: uraimo/run-on-arch-action@v2.5.1
name: Verify install
id: build
with:
@@ -98,7 +98,6 @@ jobs:
tar -xJf "node-v$NODE_VERSION-linux-$ARCH.tar.xz" -C /usr/local --strip-components=1 --no-same-owner
rm sha
rm "node-v$NODE_VERSION-linux-$ARCH.tar.xz"
npm install -g npm@latest
run: |
node --version
npm --version
@@ -109,17 +108,17 @@ jobs:
echo "Binary not found at $BIN"
exit 1
fi
build_s390x:
name: Build s390x
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node: ["16", "18", "20"]
node: ["18", "20"]
steps:
- uses: actions/checkout@v2
- uses: uraimo/run-on-arch-action@v2.1.1
- uses: uraimo/run-on-arch-action@v2.5.1
name: Verify install
id: build
with:
2 changes: 1 addition & 1 deletion lib/chromedriver.js
View file
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ function getPortFromArgs(args) {
}
process.env.PATH = path.join(__dirname, 'chromedriver') + path.delimiter + process.env.PATH;
exports.path = process.platform === 'win32' ? path.join(__dirname, 'chromedriver', 'chromedriver.exe') : path.join(__dirname, 'chromedriver', 'chromedriver');
exports.version = '116.0.5845.96';
exports.version = '117.0.5938.88';
exports.start = function (args, returnPromise) {
let command = exports.path;
if (!fs.existsSync(command)) {
138 changes: 77 additions & 61 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "chromedriver",
"version": "116.0.0",
"version": "117.0.0",
"keywords": [
"chromedriver",
"selenium"
@@ -41,6 +41,6 @@
"typescript": "^5.1.6"
},
"engines": {
"node": ">=16"
"node": ">=18"
}
}
2 changes: 1 addition & 1 deletion testInstall.js
View file
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@ const os = require('os');
const path = require('path');
const fs = require('fs');
const spawnSync = require('child_process').spawnSync;
const versions = ['16', '18', '20'];
const versions = ['18', '20'];
const tempInstallPath = path.resolve(os.tmpdir(), 'chromedriver-test');
const packedFile = path.resolve(tempInstallPath, 'chromedriver.tgz');