-
-
Notifications
You must be signed in to change notification settings - Fork 188
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: giggio/node-chromedriver
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 117.0.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: giggio/node-chromedriver
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 117.0.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 6 files changed
- 2 contributors
Commits on Sep 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 87e8749 - Browse repository at this point
Copy the full SHA 87e8749View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92e5845 - Browse repository at this point
Copy the full SHA 92e5845View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d6a5d6 - Browse repository at this point
Copy the full SHA 2d6a5d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a81ea10 - Browse repository at this point
Copy the full SHA a81ea10View commit details
Commits on Sep 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e77c025 - Browse repository at this point
Copy the full SHA e77c025View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13b621c - Browse repository at this point
Copy the full SHA 13b621cView commit details -
Configuration menu - View commit details
-
Copy full SHA for afe9bf9 - Browse repository at this point
Copy the full SHA afe9bf9View commit details
Commits on Sep 25, 2023
-
Creates the intermediate tmp folder before attempting to copy CHROMED…
…RIVER_FILEPATH to it. Copying the binary no longer worked, unless the destination tmp folder already existed. Steps to reproduce: - rm -Rf /tmp/117.0.5938.92/chromedriver/ - CHROMEDRIVER_FILEPATH="/yourpathto/chromedriver" node node_modules/chromedriver/install.js Failed with: ``` ChromeDriver installation failed Error: ENOENT: no such file or directory, copyfile '/tmp/chromedriver' -> '/tmp/117.0.5938.92/chromedriver/chromedriver-linux64/chromedriver' at Object.copyFileSync (node:fs:2894:3) at extractDownload (/home/anastasios/Sources/cloud/web/node_modules/chromedriver/install.js:364:8) at install (/home/anastasios/Sources/cloud/web/node_modules/chromedriver/install.js:70:13) at process.processTicksAndRejections (node:internal/process/task_queues:95:5) { errno: -2, syscall: 'copyfile', code: 'ENOENT', path: '/tmp/chromedriver', dest: '/tmp/117.0.5938.92/chromedriver/chromedriver-linux64/chromedriver' } ``` After this change it succeeds.
Configuration menu - View commit details
-
Copy full SHA for 6c4011c - Browse repository at this point
Copy the full SHA 6c4011cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ce13f36 - Browse repository at this point
Copy the full SHA ce13f36View commit details -
404 status throws errors, we are catching that.
Configuration menu - View commit details
-
Copy full SHA for 82a6380 - Browse repository at this point
Copy the full SHA 82a6380View commit details
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.