Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: split examples to alone repo #1775

Closed
thinkerou opened this issue Feb 21, 2019 · 6 comments
Closed

Proposal: split examples to alone repo #1775

thinkerou opened this issue Feb 21, 2019 · 6 comments
Milestone
1.4

Comments

@thinkerou
Copy link
Member

For making the gin repo simple and reducing dependencies, I suggest we create one repo gin-gonic/examples saves example code.

cc @javierprovecho @appleboy

thanks!
@thinkerou thinkerou mentioned this issue Feb 21, 2019
Merged
6 tasks
@solarhell
Copy link

LGTM. Especially when i am using go module.

@thinkerou thinkerou added this to the 1.x milestone Feb 24, 2019
@thinkerou
Copy link
Member Author

repo has created and moved code, please see https://github.com/gin-gonic/examples

@solarhell
Copy link

solarhell commented Mar 1, 2019 •
edited

I have another question: do you need to remove some unused deps from go.mod and release a new version for gin? Just want to know 😉. @thinkerou

@thinkerou
Copy link
Member Author

thinkerou commented Mar 1, 2019 •
edited

@solarhell gin1.4 should not remove examples, it will be removed to gin1.5.
@solarhell merged gin1.4.

@appleboy
Copy link
Member

appleboy commented Mar 1, 2019 •
edited

@thinkerou Add repo link of example in README.

@thinkerou thinkerou modified the milestones: 1.x, 1.4 Mar 1, 2019
@thinkerou
Copy link
Member Author

@appleboy OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
3 participants
@appleboy @thinkerou @solarhell