Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute mask sizes more carefully in DensityFiltration #512

Open
ulupo opened this issue Oct 4, 2020 · 0 comments
Open

Compute mask sizes more carefully in DensityFiltration #512

ulupo opened this issue Oct 4, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ulupo
Copy link
Collaborator

ulupo commented Oct 4, 2020

Currently, the logic in

self._size = int(np.ceil(
pairwise_distances([[0]], [[self.radius]], metric=self.metric,
**self.metric_params)
))

assumes a fair amount form the metric used. In particular, it assumes that the metric has a counterpart in 1D and that a cubical "container" for the appropriate mask can be found purely by considering this 1D counterpart.

@ulupo ulupo added the enhancement New feature or request label Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant