-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure AssetStore in Digital slide archive #3375
Comments
Hi @javier-alvarez , could you describe the changes necessary to support this? I could see us accepting the changes if they're small and low-risk. I would assume this would be some tweaks to the S3 assetstore adapter? |
Hi again. I've started looking into how to do this. I have deployed Flexify.IO, which "transparently converts S3 API to Azure Blob API", on an Azure virtual machine. I have added the account on S3 Browser as shown in How to Enable Amazon S3 API for Azure Blob Storage. All I needed was the S3-compatible REST endpoint, the access key ID and the secret access key. I can't do the same on Girder because it requires an "S3 bucket name", which doesn't apply here. Do you think it would be feasible to adapt girder so it is simply "S3 compatible", not necessarily with AWS? |
Do you have a sense of how much engineering is required to support that? I'm wondering if it makes more sense to extend the S3AssetstoreAdapter with a custom subclass to support this service. If you could show what that looks like, we could make a decision of whether it would be reasonable to upstream it. |
I need to start looking into that, it's hard to estimate for now. I will experiment with generalizing to S3-compliant storages and also to Azure Blob Storage directly, and keep you posted. If things seem to work, I will submit a PR and we can discuss whether you'd like it upstream as well. |
Sounds great, thanks! |
As I just verified that I can import from a mounted folder (see #3379, I was using the minimal deployment version), we will postpone the direct integration with Azure Blob Storage for now. |
Would you like to receive a pull request to support Azure blob in your AssetStore?
Thanks,
Javier
The text was updated successfully, but these errors were encountered: