Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File paths from docker transforms should be wrapped in quotes #351

Open
subdavis opened this issue Feb 6, 2020 · 1 comment
Open

File paths from docker transforms should be wrapped in quotes #351

subdavis opened this issue Feb 6, 2020 · 1 comment

Comments

@subdavis
Copy link
Contributor

subdavis commented Feb 6, 2020

I don't think it's docker-py's burden to do anything other than ' '.join(container_args)

If our transforms return strings that might have spaces, they also need to be quoted.

Also random note:

the item to a bind mounted volume, and returns the container path of the directory.

I believe this returns a full file path, not a parent directory path.

@subdavis
Copy link
Contributor Author

subdavis commented Feb 6, 2020

HA! I opened #327 like a year ago then forgot about it.

Looks like this is still an issue. Not sure why that issue was closed.

Reproduce with Dockerfile:

FROM debian:buster-slim

COPY entrypoint.sh /
RUN chmod +x /entrypoint.sh

ENTRYPOINT ["/entrypoint.sh"]

entrypoint.sh:

#!/bin/sh -e

ls "$1"

if any part of the path has spaces and you use any of the girder docker transforms as input paths, you get a no such file or directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant