Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I pass env variables from within DSA to a image that is being added through slicer web task #387

Open
lomshabhishek opened this issue Oct 16, 2023 · 0 comments

Comments

@lomshabhishek
Copy link

lomshabhishek commented Oct 16, 2023

I want to pass secret env variables when a new docker image is pulled and as well as eventually when it is used to create container to serve user request.

@manthey 's response
DigitalSlideArchive/digital_slide_archive#300


We have the ability to use environment variables to set parameters in a job that is being run, but it wouldn't be used for secrets (see near the end of the README here: https://github.com/girder/slicer_cli_web). You can also add environment parameters in part of the docker-params markup that a cli has; but that also wouldn't be appropriate for secrets.

There currently isn't a way to do this for secrets -- we'd have to make a change to girder_worker to pass specific environment variable. We could make it so that all environment variables that start with some prefix would be passed without that prefix into all running containers (or maybe it needs to be more constrained than that). Then, you would set environment variables in the main girder or girder worker processes(via docker-compose a environment key, for instance).

We should make an issue in the girder-worker repo and further discuss what would make sense.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant