Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should encoding="PNG" be default? #1105

Open
banesullivan opened this issue Apr 12, 2023 · 3 comments
Open

Should encoding="PNG" be default? #1105

banesullivan opened this issue Apr 12, 2023 · 3 comments

Comments

@banesullivan
Copy link
Contributor

I noticed that JPEG seems to be the default encoding when opening a tile source. With the addition of the Jupyter visualizer in #1065, it may benefit users to have encoding="PNG" be the default to avoid opaque/black tiles outside of the image bounds:

Default encoding='PNG'
Screen Shot 2023-04-12 at 11 06 04 AM Screen Shot 2023-04-12 at 11 06 18 AM
@banesullivan
Copy link
Contributor Author

I could also have the tile endpoint force PNG encoding in #1065, but I'm trying to let all configurations be entirely controlled by the source instance itself as maybe a user wants JPEG or some other encoding

@manthey
Copy link
Member

manthey commented Apr 18, 2023

Maybe on tiles sources with projections a PNG default, but changing this on non-projection sources increases data volume and would be a seriously breaking change. Sadly, although the jpeg standard supports having an alpha channel, essentially no one supports it.

@banesullivan
Copy link
Contributor Author

Maybe on tiles sources with projections a PNG default

+1, this makes the most sense. I'll work to implement this in a dedicated PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants