Zarr sink metadata management #1508
Conversation
annehaley
commented
Apr 17, 2024
•
annehaley
commented
- Resolves In zarr sink, set mm_x, mm_y #1482
- Resolves In zarr sink, set image description #1483
- Resolves In zarr sink, set channel names #1484
- Resolves In zarr sink, support adding associated images #1485
| @@ -653,6 +648,111 @@ def addTile(self, tile, x=0, y=0, mask=None, axes=None, **kwargs): | |||
| self.levels = int(max(1, math.ceil(math.log(max( | |||
| self.sizeX / self.tileWidth, self.sizeY / self.tileHeight)) / math.log(2)) + 1)) | |||
|
|
|||
| def addAssociatedImage(self, image): | |||
There was a problem hiding this comment.
We should change this method signature to def addAssociatedImage(self, image, imageKey=None), where imageKey is an optional string that we store and can use to identify what this associated image is used for.
There was a problem hiding this comment.
Note that you couldn't set the imageKey in the vips sink (we could go back and add it eventually).
There was a problem hiding this comment.
We don't currently read in the imageKey when finding associated images in zarr files. If we used the key as the zarr group OR used associated_, then we could use the group name on read (this means changing https://github.com/girder/large_image/blob/master/sources/zarr/large_image_source_zarr/__init__.py#L323-L324 and associated areas).
There was a problem hiding this comment.
Ok, I made this change in 8976f3d. We now store self._associatedImages as a dict.
