Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start file/item/image/folder selector at current selection #133

Open
manthey opened this issue Dec 7, 2020 · 4 comments
Open

Start file/item/image/folder selector at current selection #133

manthey opened this issue Dec 7, 2020 · 4 comments

Comments

@manthey
Copy link
Member

manthey commented Dec 7, 2020

Use the Girder browser widget option to start selections at current values, highlighting the selected item associated with the item/file/image.

@BryonLewis
Copy link
Collaborator

Almost there with default types and some sensible switching between single files and the regEx expressions where they will default to the same folder when swapping.

Need to add in some testing and do some cleanup to the minor issues.

scaledResource.mp4

@manthey
Copy link
Member Author

manthey commented Dec 22, 2020

@BryonLewis Either as part of this or as a separate PR, I'd like to use the paging interface for the browser widget. I know we'll have cases with thousands of items in a folder.

@BryonLewis
Copy link
Collaborator

@manthey okay I'm adding it in, the basics look like they work as far as the pagination and going to the right page. Having some issues with the scrolling (could be to the way I initialize, I'll look into it further).

@BryonLewis
Copy link
Collaborator

Looks like I may need to fix some minor things in girder for this to work:

  • It looks like the default for /item/{id}/position sorts by 'lowerName' but the display seems to be always by 'name'. This can cause issues with pagination
  • I don't know if scroll behavior changed in the browsers but there was an addition that was done to incrementally scroll which doesn't seem to be needed anymore in either firefox or chrome. I'll do a bit more testing with this.
  • Only other thing is finding a better way to do the injecting to do the initial highlighting in regEx mode.

Video below has the girder Browser Widget changes in there as well.

quickPaginatedDemo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants