duet-commit adds Signed-off-by while commit --amend adds Co-authored-by

[bengolder]

Context for all the behaviors below

• with git duet assigned to two authors, for example git duet bg tg
• and with GIT_DUET_CO_AUTHORED_BY set to 1

# in .zshrc

# git duet
export GIT_DUET_CO_AUTHORED_BY=1

Expected behavior

When I run git duet-commit, I expect it to add Co-authored-by: with the name of the second author to my commit.

Actual behavior

When I run git duet-commit, it adds Signed-off-by: with the name of the second author to my commit.

Amend works as expected

When I run git commit --amend, it adds Co-authored-by: with the name of the second author to my commit.

Additional debugging steps I've attempted

These have not changed the behavior described above

• running git init in my existing local git repository
• setting GIT_DUET_GLOBAL to 1, and running git init again

---

Is there any more info I can provide to help debug?

[jszwedko]

Hey!

Apologies in the delay in looking at this. What version are you trying? I tried to reproduce this with 0.10.0 just now but was unable to. Steps:

$ cat <<-EOF > ~/.git-authors
authors:
  jd: Jane Doe; jane
  fb: Frances Bar
email:
  domain: awesometown.local
EOF
$ git init foo
$ cd foo
$ export GIT_DUET_CO_AUTHORED_BY=1
$ git duet jd fb
$ touch bar
$ git add .
$ git duet-commit -m 'test'
$ git show
commit 6ae9cbd0ebba8c010511a5076e2d1c1f762ebee8 (HEAD -> master)
Author: Jane Doe <jane@awesometown.local>
Commit: Frances Bar <f.bar@awesometown.local>

    test

    Signed-off-by: Frances Bar <f.bar@awesometown.local>
    Co-authored-by: Frances Bar <f.bar@awesometown.local>

diff --git a/bar b/bar
new file mode 100644
index 0000000..e69de29

Is there any chance you could try to come up with more complete list of steps that triggers the bug for you?