Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amending a commit can sometimes lead to duplicate Signed-off-by lines in commit message #36

Open
nertzy opened this issue Nov 7, 2016 · 4 comments

Comments

@nertzy
Copy link

nertzy commented Nov 7, 2016

Is there a way we can detect an amend and prevent the duplicate sign off?

@jszwedko
Copy link
Member

Good question, I'm not sure off the top of my head, but it is definitely something we could explore.

Thank you for the suggestion!

@dideler
Copy link
Contributor

dideler commented May 9, 2017

Just a thought. Could have a pre-commit hook that checks if the commit has the same author and committer. Not sure what the best way is to do that, maybe a git cat-file -p <sha>?

@Jackman3005
Copy link

Jackman3005 commented Sep 26, 2017

👍

@jszwedko
Copy link
Member

Recently discovered via #57 that you can change the default trailer behavior to eliminate the duplicates with: git config [--global] trailer.ifexists addIfDifferent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants