Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests are functionally disabled due to if $TRAVIS #5658

Open
bk2204 opened this issue Feb 23, 2024 · 4 comments
Open

Some tests are functionally disabled due to if $TRAVIS #5658

bk2204 opened this issue Feb 23, 2024 · 4 comments

Comments

@bk2204
Copy link
Member

bk2204 commented Feb 23, 2024

We have some tests in our testsuite that are functionally disabled because they run if $TRAVIS, which is always true if the TRAVIS environment variable is not set (fun shell fact!). Many of these deal with our TLS certificate handling, and they are broken in CI for various reasons depending on the OS.

We should probably investigate what's wrong and how to fix it, since these tests are never run unless TRAVIS is set to a shell command returning false. I should note that at least some of them pass on my Ubuntu 23.10 laptop, so simply reproducing on Linux is not sufficient to trigger the problem.

@chrisd8088
Copy link
Contributor

I've discovered that if $TRAVIS problem myself in the past and have a stale set of updates to the test suite to remove the variable, but it's been about 18 months since I looked at it, so let me dust that off.

@bk2204
Copy link
Member Author

bk2204 commented Feb 23, 2024

I had discovered it in the past as well and tried to open a PR (#5615), but got distracted with other things after everything got angry and red. I very much appreciate any assistance you can offer here.

I anticipated you might inquire about it in #5657, which adds a more abbreviated adjacent test, so I thought I'd document it so we didn't lose track of it in the PR comments.

@Elhazinforever

This comment has been minimized.

@Elhazinforever

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants