Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit tests in git-temporal-react #23

Closed
littlebee opened this issue Jan 19, 2020 · 1 comment · Fixed by #29
Closed

Fix unit tests in git-temporal-react #23

littlebee opened this issue Jan 19, 2020 · 1 comment · Fixed by #29
Assignees
Labels
tech debt test first ;) (really "just test!"; don't care when)

Comments

@littlebee
Copy link
Contributor

This is mia culpa. During the last big redesign and refactor I made an intentional decision to not update the unit tests for git-temporal-react. I didn't know if this would be The final design/layout and didn't want to update them n more times.

When the tests in gtr last worked, they were running at about 90% coverage. I'm less concerned with overall coverage percentage these days and would prefer better tests instead of more coverage. I've also never been entirely sure that shallow unit tests provide as much peace of mind as good integration or end to end testing. I will add another ticket for doing the E2E test work.

Requirements:

  • Let's shoot for >= 70% cov and some quality unit tests that aren't all just snapshot testing?.
  • All tests that are there should pass
  • Quality tests around the reselect selectors
@littlebee littlebee self-assigned this Jan 19, 2020
@littlebee littlebee added tech debt test first ;) (really "just test!"; don't care when) labels Jan 19, 2020
@littlebee
Copy link
Contributor Author

One of the issues I've encountered so far is with the use of Enzyme not supporting hook functions with shallow rendering. This is a known thing with Enzyme.

Kinda been rethinking testing in general and am wondering if it would be better to adopt the practices backing React Testing Library

I think this will end up being dependent on upgrading react-redux #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt test first ;) (really "just test!"; don't care when)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant