Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated HTML anchors on page for git diff #1331

Open
mast-eu opened this issue Mar 27, 2019 · 1 comment
Open

duplicated HTML anchors on page for git diff #1331

mast-eu opened this issue Mar 27, 2019 · 1 comment

Comments

@mast-eu
Copy link

mast-eu commented Mar 27, 2019

The page https://git-scm.com/docs/git-diff contains two options

  • --color-moved[=<mode>] (link) and
  • --color-moved-ws=<modes> (link),

which have both a parameter no.

The HTML anchor for both parameters is identical: https://git-scm.com/docs/git-diff#Documentation/git-diff.txt-no
The link leads to --color-moved=no. It is impossible to link directly to --color-moved-ws=no, because this is the second occurrence of the anchor within the same page.

#987 describes the same issue on another page.

@peff
Copy link
Member

peff commented Mar 28, 2019

Yes as #987 hints at, I don't think we can fix this without rewriting how the anchors are added, because the current regex doesn't know about the hierarchy of items. I think we'd need to integrate more with asciidoc's view of the document, like the suggestion from asciidoctor/asciidoctor#2717.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants