Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to the External Links page. #1343

Open
1 task done
amishscientist opened this issue May 17, 2019 · 7 comments
Open
1 task done

Add links to the External Links page. #1343

amishscientist opened this issue May 17, 2019 · 7 comments

Comments

@amishscientist
Copy link

I would like to add the following links to the External Links Page

I guess I'm looking for approval of the links before going off and making code updates followed by the pull request.

Please make sure you are NOT reporting a problem about git itself

  • This is not an issue about
    • the Git documentation (a.k.a. man/help pages, i.e. anything with a URL starting with https://git-scm.com/docs), which should be raised with the community,
    • the contents of the Pro Git book (i.e. anything with a URL starting with https://git-scm.com/book or its PDF versions), which should be raised at progit/progit2.
    • Git itself, which should also be raised with the community, or
    • Git for Windows, which should be raised at git-for-windows/git.
    • and is actually about the website itself (e.g. website-specific content, JS, or CSS that doesn't seem to be doing its job correctly).
@peff
Copy link
Member

peff commented May 17, 2019

I skimmed over the content in both of them, and they look pretty reasonable. I think the only real downside to adding links to new resources is that they would turn out to be misleading or wrong, and our link would endorse them and provide extra confusion. But as a general rule, if a third party thinks the content is useful and nobody has complained otherwise, I think it's worth linking and giving the benefit of the doubt (that's certainly what we've done for books).

And in both of these cases, the material seems to be presented in different ways than what's already linked on the site.

So yes, a PR would be welcome. Thanks!

@pedrorijo91
Copy link
Member

thanks for the raising this @amishscientist .

we would love to have you doing a PR adding those links. In case you need some guidance, the files you'd need to change are under https://github.com/git/git-scm.com/tree/master/app/views/doc

@adsingh14
Copy link
Contributor

@pedrorijo91 it seems that issue author has not added the links.

@pedrorijo91
Copy link
Member

true. would you be interested in doing it @adsingh14 ? (or were you planning but forgot @amishscientist ?)

@amishscientist
Copy link
Author

amishscientist commented Dec 22, 2021 via email

@adsingh14
Copy link
Contributor

true. would you be interested in doing it @adsingh14 ? (or were you planning but forgot @amishscientist ?)

I would like to pass it to the author. I supposed that several stale issues needs to be 'closed'. :)

@amishscientist
Copy link
Author

amishscientist commented Dec 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants